New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix creating dict with JIT disabled #4921
Conversation
When using `NUMBA_DISABLE_JIT=1` we still want `dictobject.new_dict` to work, for example to measure coverage and such things.
Seems reasonable to me. |
Following on Stuart's suggestion from #4920, the test could be made to more directly verify the DISABLE_JIT behavior with this test pattern: numba/numba/tests/test_debug.py Lines 184 to 188 in 92dbdb9
|
* master: (252 commits) Use class name in the tuple type name Fix tuple type used for stararg Remove deadcode Fix test failure depending on pointer size Revert "Replace `arange` with `ones`" Revert "Fix arange type in list tests" Respond to feedback Add problematic case for tuple in stararg Attempt to fix numba#4944 Implement sort/sorted with key. Clarify comments Use guarded function Apply suggestions from code review Undo "fix" to block-0 loop header because it is causing segfault in numba.tests.test_closure.TestObjmodeFallback.test_issue3239. Fixes a bug in the relabelling logic in literal_unroll. Set the calltype on the newly formed SetItem when we replace StaticSetItem with regular SetItem. Fix the extraction of code to common function gen_wrap_if_not_known. Clean up Update looplifting test that now improved in py2 because of the new loop-canonicalization pass Fix test error on windows ...
This implements most methods for creating typed-dicts with JIT disabled and tests those.
So the |
When using `Dict()` with DISABLE_JIT we now return a `dict` which should then survive any kind of mutation.
Fixed |
looks good! |
When using
NUMBA_DISABLE_JIT=1
we still wantdictobject.new_dict
towork, for example to measure coverage and such things.