Better handling of prange with multiple reductions on the same variable. #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an assignment with a left-hand side to the reduction variable's name. This fixes problems with cases where there are multiple assignments to the reduction variable in the parfor.
… another test I thought of for where the same reduction variable is used twice but with different operators.
… reduction statements with different/conflicting operators.
sklam
reviewed
Dec 16, 2019
numba/parfor.py
Outdated
| first_red_func = node.value.fn | ||
| else: | ||
| if first_red_func != node.value.fn: | ||
| raise ValueError("Reduction variable " + param + |
There was a problem hiding this comment.
I think it'd be better to raise an numba.errors.UnsupportedError with loc set to something like node.loc.
sklam
added
4 - Waiting on author
As title.
Fix up error class and test.
stuartarchibald
approved these changes
Dec 19, 2019
stuartarchibald
added
4 - Waiting on CI
|
CI passed, ready to merge |
seibert
added
5 - Ready to merge
stuartarchibald
added a commit
to stuartarchibald/numba
that referenced
this pull request
Dec 19, 2019
As title. numba#4922 was fixed by numba#4935.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4922