Move overload of literal_unroll to avoid circular dependency that breaks Python 2.7 #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Internal CI: |
|
Thanks for the fix. Happy to merge. But I do wonder how this passed CI in the first place? Perhaps the 2.7 build missed it in its slice? |
stuartarchibald
added
5 - Ready to merge
stuartarchibald
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 doesn't seem to mind, but Python 2.7 can't resolve this dependency. Moved the overload of
literal_unrollto the same location andliterallyand renamed the file to be more generic.