Implement sort/sorted with key. #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title.
stuartarchibald
force-pushed
the
wip/list_w_key_tests
branch
from
576ebd9
to
ae20b1c
Compare
sklam
reviewed
Dec 17, 2019
numba/targets/listobj.py
Outdated
| _sort_check_key(key) | ||
| _sort_check_reverse(reverse) | ||
|
|
||
| if (isinstance(key, (types.NoneType, types.Omitted)) or key is None): |
There was a problem hiding this comment.
use cgutils.is_nonelike() instead
There was a problem hiding this comment.
Why is this in cgutils? It's typing not codegen?
There was a problem hiding this comment.
good point. there's no typing util either. will need to sort that out later.
As title
sklam
approved these changes
Dec 18, 2019
sklam
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.