implement hoistable getitem for typed-list #5184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
partially adresses #4584 |
This implements exporting the base pointer of the typed-list `items` array and then implements `getitem` in builder code. This has the advantage, that the `getitem` can in principle be hoisted / loop lifted.
esc
force-pushed
the
typed_list/hoistable_getitem
branch
from
799eff4
to
6ca716e
Compare
|
This was implemented in #6278. Closing as resolved. |
stuartarchibald
added
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements exporting the base pointer of the typed-list
itemsarray and then implements
getitemin builder code. This has theadvantage, that the
getitemcan in principle be hoisted / loop lifted.