Check type getitem #5549
Merged
Check type getitem #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that calls to `Type.__getitem__` are slices with no start or stop (e.g. `intp[:]`). Raises a KeyError if not. Previously, `list(intp)` would infinite loop.
|
Thanks for the PR, much appreciated. Looks like there's a couple of test fails on CI at present, marked as "In progress". |
|
Yeah there are several places that depend on the old behavior that I need to fix still. I wanted to see what you thought about it, or if there were any valid use cases of indexing by something other than an open slice that I'm not aware of. |
From `BaseTuple.from_types` we can pass a list of types as well
|
@stuartarchibald I think the CI errors are fixed. |
|
Thanks for fixing, queued for review. |
sklam
reviewed
May 21, 2020
| @@ -257,7 +257,10 @@ def add_indices_to_kernel(self, kernel, index_names, ndim, | |||
| const_index_vars[dim], loc) | |||
| new_body.append(ir.Assign(getitemcall, getitemvar, loc)) | |||
| # Get the type of this particular part of the index tuple. | |||
| one_index_typ = stmt_index_var_typ[dim] | |||
| if isinstance(stmt_index_var_typ, types.ConstSized): | |||
There was a problem hiding this comment.
nvm, I found the affected test test_basic81 (numba.tests.test_stencils.TestManyStencils)
sklam
added
4 - Waiting on author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that calls to
Type.__getitem__are slices with no start or stop (e.g.intp[:]).Raises a KeyError if not.
Previously,
list(intp)would infinite loop.