Fix unifying undefined first class function types issue. #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
stuartarchibald
added a commit
to stuartarchibald/numba
that referenced
this pull request
Apr 28, 2020
As title. For context see comment on numba#5626.
stuartarchibald
added a commit
to stuartarchibald/numba
that referenced
this pull request
Apr 28, 2020
As title. For context see comment on numba#5626.
pearu
changed the title
sklam
reviewed
Apr 29, 2020
| @@ -532,8 +532,6 @@ def unified_function_type(numba_types, require_precise=True): | |||
| if isinstance(t, types.UndefinedFunctionType): | |||
| if undefined_function is None: | |||
| undefined_function = t | |||
| else: | |||
| assert undefined_function == t | |||
There was a problem hiding this comment.
I'm trying to understand this patch. I see that when this condition is reached, this function will return None. Couldn't it return None at this point?
sklam
added
3 - Ready for Review
4 - Waiting on author
40 tasks
stuartarchibald
added
5 - Ready to merge
|
Indirectly merged by #5658 thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #5615 .