Fix #5570. Incorrect race variable detection due to SSA naming. #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned names in parfors params.
sklam
changed the title
Comment on lines
+3193
to
+3194
| except ir.NotDefinedError: | ||
| # XXX: it's a bug that something references an undefined name |
There was a problem hiding this comment.
Should this actually just raise?
There was a problem hiding this comment.
No, some passes are not registering names into scope. There are other similar situation where we just ignore the NotDefinedError in parfor passes
numba/parfors/parfor.py
Outdated
| # XXX: it's a bug that something references an undefined name | ||
| return k | ||
|
|
||
| keep = set(races) |
There was a problem hiding this comment.
Perhaps s/keep/races1/ so as to match up with the docstring?
numba/parfors/parfor.py
Outdated
|
|
||
| keep = set(races) | ||
| for rv in races: | ||
| if any(unversion(rv) == unversion(pv) for pv in params): |
There was a problem hiding this comment.
could the unversion(pv) for pv in params be hoisted as loop invariant?
stuartarchibald
added
4 - Waiting on author
sklam
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Apr 30, 2020
stuartarchibald
added
5 - Ready to merge
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
40 tasks
sklam
added a commit
that referenced
this pull request
Apr 30, 2020
Fix #5570. Incorrect race variable detection due to SSA naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5570