Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with SSA not minimal #5686

Merged
merged 5 commits into from May 19, 2020
Merged

Fix issue with SSA not minimal #5686

merged 5 commits into from May 19, 2020

Conversation

sklam
Copy link
Member

@sklam sklam commented May 8, 2020

Fixes #5678

@sklam sklam marked this pull request as ready for review May 8, 2020 21:18
@sklam sklam added this to the Numba 0.50RC milestone May 8, 2020
sklam
sklam commented May 8, 2020
View reviewed changes
numba/core/ssa.py
phi_locations = states['phi_locations']

if label in phi_locations:
scope = states['scope']
Copy link
Member Author

@sklam sklam May 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code in this if block is unchanged, just unindented

@stuartarchibald
Copy link
Contributor

Thanks for the patch. I've manually checked this, it looks correct. Did you want to consider any of those places in parfors where we had to do unversioned_name mangling or get this in and then take a look?

@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels May 15, 2020
@stuartarchibald stuartarchibald self-assigned this May 15, 2020
@stuartarchibald
Copy link
Contributor

Please could you resolve the conflicts by merging master into this branch. Thanks!

@sklam
Merge branch 'master' into fix/ssa_mini
d763438 
# Conflicts:
#	numba/core/ssa.py
@sklam
Copy link
Member Author

sklam commented May 18, 2020

RE: #5686 (comment)

Let's get this in. We will look later.

@sklam sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels May 18, 2020
@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels May 19, 2020
stuartarchibald
stuartarchibald approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@sklam sklam merged commit 635a99f into numba:master May 19, 2020
@sklam sklam deleted the fix/ssa_mini branch May 19, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees

@stuartarchibald stuartarchibald

Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.50 RC
Development

Successfully merging this pull request may close these issues.

bug in analysis NumbaParallelSafetyWarning
2 participants
@sklam @stuartarchibald