Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to numpy ufunc signature docs #5963

Merged
merged 2 commits into from Jul 9, 2020
Merged

Fix broken link to numpy ufunc signature docs #5963

merged 2 commits into from Jul 9, 2020

Conversation

leouieda
Copy link
Contributor

@leouieda leouieda commented Jul 6, 2020

In the guvectorize reference, the link to the documentation for numpy ufunc signatures was broken. The docs moved to the numpy.org domain. This PR updates that link.

In the guvectorize reference, the link to the numpy ufunc signature 
documentation was broken. The docs moved to the numpy.org domain.
@stuartarchibald
Copy link
Contributor

Thanks for the PR, I've queued it for review.

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. One minor comment to resolve else good to merge!

docs/source/reference/jit-compilation.rst Outdated Show resolved Hide resolved
@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Jul 7, 2020
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
@leouieda
Copy link
Contributor Author

leouieda commented Jul 7, 2020

@stuartarchibald you're absolutely right, sorry about that. Thanks for all the work on numba! It makes my life a whole lot easier 🙂

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review labels Jul 7, 2020
@stuartarchibald stuartarchibald modified the milestones: Backlog, Numba 0.51 RC Jul 7, 2020
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stuartarchibald
Copy link
Contributor

@stuartarchibald you're absolutely right, sorry about that. Thanks for all the work on numba! It makes my life a whole lot easier slightly_smiling_face

No problem. Great to hear that Numba's working well for you and congratulations on your first contribution to Numba :)

@stuartarchibald stuartarchibald self-assigned this Jul 8, 2020
@sklam sklam merged commit ccdf613 into numba:master Jul 9, 2020
@leouieda leouieda deleted the patch-1 branch July 10, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants