[WIP] Add no_unliteral flag to overloads #6043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag avoids calling overloads again without literal types if the first call with literals was unsuccessful.
|
@stuartarchibald This is the no_unliteral flag I mentioned last week. We have been using this significantly for a while now, but this may need to be expanded to support non-literal only case as well. Feel free to take code from this branch or just modify it. |
|
This pull request is marked as stale as it has had no activity in the past 3 months. Please respond to this comment if you're still interested in working on this. Many thanks! |
github-actions
bot
added
the
abandoned - stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag avoids calling overloads again without literal types if the first call with literals was unsuccessful.
Closes #5411.
I think having the opposite option of just calling without literals is also helpful to avoid overspecialization. So this flag can be renamed/expanded to support both.