Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUDA: Add mapped_array_like and pinned_array_like #6092

Merged
merged 1 commit into from Sep 8, 2020
Merged

CUDA: Add mapped_array_like and pinned_array_like #6092

merged 1 commit into from Sep 8, 2020

Conversation

gmarkall
Copy link
Member

@gmarkall gmarkall commented Aug 6, 2020

Includes:

  • Code changes to add mapped_array_like and pinned_array_like.
  • Documentation updates and a couple of small doc fixes in related areas.
  • Tests of device_array_like updated to test all the *_array_like functions.

mapped_array_like is not added to the simulator because mapped_array doesn't exist in the simulator at present (See #6047).

See also #5131 - this doesn't add everything in that issue, but is a start.

@gmarkall gmarkall added the CUDA CUDA related issue/PR label Aug 6, 2020
@gmarkall gmarkall added this to the Numba 0.52 RC milestone Aug 6, 2020
stuartarchibald
stuartarchibald approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, looks good.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm and removed 3 - Ready for Review labels Sep 8, 2020
@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_100.

@stuartarchibald
Copy link
Contributor

Buildfarm passed.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Sep 8, 2020
@sklam sklam merged commit 46f663c into numba:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR
Projects
None yet
Milestone
Numba 0.52 RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmarkall @stuartarchibald @sklam