Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #6110

Merged
merged 1 commit into from Aug 25, 2020
Merged

Update CONTRIBUTING.md #6110

merged 1 commit into from Aug 25, 2020

Conversation

stuartarchibald
Copy link
Contributor

As title.

Closes #5991

@stuartarchibald stuartarchibald added needs initial review This PR needs an initial review to check the code change is well formed, documented, efficient etc. 3 - Ready for Review labels Aug 11, 2020
@stuartarchibald stuartarchibald added this to the Numba 0.52 RC milestone Aug 11, 2020
esc
esc approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell checked locally and viewed the markdown rendering at: https://github.com/stuartarchibald/numba/blob/fix/5991/CONTRIBUTING.md

@stuartarchibald
Copy link
Contributor Author

@esc thanks for checking, is this ready to merge?

@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review needs initial review This PR needs an initial review to check the code change is well formed, documented, efficient etc. labels Aug 25, 2020
@esc esc added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Aug 25, 2020
@esc
Copy link
Member

esc commented Aug 25, 2020

@stuartarchibald it sure is!

@stuartarchibald stuartarchibald merged commit 9e068d9 into numba:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esc esc esc approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.52 RC1
Development

Successfully merging this pull request may close these issues.

Reminder to update CONTRIBUTING.md and add "good first review" label and use it
2 participants
@stuartarchibald @esc