Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6130 objmode cache segfault #6141

Merged
merged 9 commits into from Aug 25, 2020
Merged

Fix #6130 objmode cache segfault #6141

merged 9 commits into from Aug 25, 2020

Commits on Aug 17, 2020

  1. Guard for NULL

    @sklam
    sklam committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    42bfd1f View commit details
    Browse the repository at this point in the history

  2. Fix numba#6130 by storing the referenced_envs in CompileResult

    @sklam
    sklam committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    a2f7e11 View commit details
    Browse the repository at this point in the history

  3. Test numba#6130

    @sklam
    sklam committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    0d82666 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Apply suggestions from code review 

    Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
    @sklam @stuartarchibald
    sklam and stuartarchibald committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    21ce0cc View commit details
    Browse the repository at this point in the history

  2. Make sure read_const return value is checked against NULL value

    @sklam
    sklam committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    84591d5 View commit details
    Browse the repository at this point in the history

  3. Check for NULL in env.consts

    @sklam
    sklam committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    83cbb69 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Resolve comments in code review

    @sklam
    sklam committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    efff4b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Apply suggestion from code review 

    - changed to RuntimeError and fix error message
- added suggested comment
    @sklam
    sklam committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    62d2a8b View commit details
    Browse the repository at this point in the history

  2. Fix typo bug

    @sklam
    sklam committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    24e6916 View commit details
    Browse the repository at this point in the history