#5425 continued #6165
Merged
#5425 continued #6165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added this to the 0.52RC milestone for now - unless it's critical for 0.51.1? |
0.52RC is fine, thanks. |
sklam
reviewed
Aug 25, 2020
numba/tests/test_withlifting.py
Outdated
Comment on lines
537
to
539
| self.assertIn("Example code: with objmode" | ||
| "(t='<add_type_as_string_here>')", | ||
| exstr) |
There was a problem hiding this comment.
odd indentation here---i didn't see exstr at first. can the string "Example code..." be move to the same level as exstr?
There was a problem hiding this comment.
done in 210a8f2
As title
stuartarchibald
added
4 - Waiting on reviewer
sklam
added
5 - Ready to merge
sklam
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #5425
Closes #5425