-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for np.asarray_chkfinite [WIP] [need help] #6279
Closed
rishabhvarshney14
wants to merge
13
commits into
numba:master
from
rishabhvarshney14:np_asarray_chkfinite
Closed
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
01b5c6b
added implementation of np asarray_chkfinite
rishabhvarshney14 cb78e0e
add support for asarray_chkfinite
rishabhvarshney14 bc5beb4
fixed flake8 error and remove branch.diff
rishabhvarshney14 b9491c1
fixed flake8 errors
rishabhvarshney14 a50fa05
flake8 fixed
rishabhvarshney14 0ef86c9
flak8 fix
rishabhvarshney14 1be9be5
improved implementation
rishabhvarshney14 a578490
changed to np.isfinite
rishabhvarshney14 a05d6b1
removed order
rishabhvarshney14 c24e3aa
changed dtype.dtype to as_dtype
rishabhvarshney14 c9960c4
added test for dtype
rishabhvarshney14 8398763
Merge pull request #1 from numba/master
rishabhvarshney14 4a448ae
added test for dtype
rishabhvarshney14 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4159,6 +4159,27 @@ def np_select_arr_impl(condlist, choicelist, default=0): | |
|
||
return np_select_arr_impl | ||
|
||
|
||
@overload(np.asarray_chkfinite) | ||
def np_asarray_chkfinite(a, dtype=None, order='C'): | ||
|
||
msg = "The argument to np.asarray_chkfinite must be array-like" | ||
if not isinstance(a, (types.Array, types.Sequence, types.Tuple)): | ||
raise TypingError(msg) | ||
|
||
if is_nonelike(dtype): | ||
dt = a.dtype | ||
else: | ||
dt = dtype.dtype | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @esc Should this check that the |
||
|
||
def impl(a, dtype=None, order='C'): | ||
rishabhvarshney14 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
a = np.asarray(a, dtype=dt) | ||
if not np.all(np.isfinite(a)): | ||
rishabhvarshney14 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
raise TypingError("array must not contain infs or NaNs") | ||
rishabhvarshney14 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return a | ||
|
||
return impl | ||
|
||
#---------------------------------------------------------------------------- | ||
# Windowing functions | ||
# - translated from the numpy implementations found in: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, either that or
only the first two arguments
, but I guess that would be inconsistent with the rest of the doc?