Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IR inliner tests not self mutating. #6316

Merged
merged 1 commit into from Oct 7, 2020
Merged

Make IR inliner tests not self mutating. #6316

merged 1 commit into from Oct 7, 2020

Conversation

stuartarchibald
Copy link
Contributor

As title.

Fixes #6315

@stuartarchibald stuartarchibald added this to the Numba 0.52 RC milestone Oct 7, 2020
sklam
sklam approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch makes sure that the Dummy and DummyType are fresh in each test method. The new code is less error prone than storing them as attributes in the test instance.

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Oct 7, 2020
@sklam sklam merged commit 5eda874 into numba:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.52 RC1
Development

Successfully merging this pull request may close these issues.

mainline @ 159510a is failing CI
2 participants
@stuartarchibald @sklam