Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 6208 continued #6324

Merged
merged 7 commits into from
Oct 8, 2020
Merged

PR 6208 continued #6324

merged 7 commits into from
Oct 8, 2020

Conversation

stuartarchibald
Copy link
Contributor

Like #6208 but for testing.

@stuartarchibald
Copy link
Contributor Author

Buildfarm ID: numba_smoketest_cpu_76

@stuartarchibald stuartarchibald added this to the Numba 0.52 RC milestone Oct 7, 2020
@stuartarchibald
Copy link
Contributor Author

Buildfarm ID: numba_smoketest_cpu_76

Passed everywhere with the exception of NumPy 1.19 because of the ediff1d issue that is nothing to do with this.

@stuartarchibald stuartarchibald mentioned this pull request Oct 8, 2020
Closed
sklam
sklam approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the test. Looks good.
Btw, the test can run on OSX as well.

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Oct 8, 2020
@sklam sklam merged commit 9381206 into numba:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Milestone
Numba 0.52 RC1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stuartarchibald @sklam