Support attribute access from other modules #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@farahhariri thanks for submitting this! Perhaps you could provide a little more context as to why this is needed or what it fixes? Thanks! |
esc
added
4 - Waiting on author
Hi @esc This is needed for when someone accesses an attribute (like a constant tuple) in another module. I will add a test case to it to show what it addresses |
|
@farahhariri excellent, test cases are always welcome. |
farahhariri
requested review from
esc,
sklam and
stuartarchibald
as code owners
added 2 commits
January 18, 2021 13:44
ehsantn
reviewed
Jan 18, 2021
added 2 commits
January 18, 2021 19:56
farahhariri
changed the title
ehsantn
approved these changes
Jan 18, 2021
sklam
added
5 - Ready to merge
sklam
added a commit
to sklam/numba
that referenced
this pull request
Jan 20, 2021
Merged
|
@farahhariri Congratulations on your first contribution to Numba! |
Thanks @stuartarchibald :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing an attribute from another module currently fails if it has a complex data type like string. This PR passes the builder object to the
get_getattrfunction and usesget_constant_genericinstead ofget_constantto retrieve attributes. A test case that shows an example that would usually fail and this PR fixes is added