Re roll 6279 #6341
Merged
Re roll 6279 #6341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartarchibald @sklam @rishabhvarshney14 would you be able to check if I cherry-picked everything appropriately? It's probably enough to look at the final diff of this PR. |
numba/tests/test_np_functions.py
Outdated
| @@ -3906,7 +3906,11 @@ def test_asarray_chkfinite(self): | |||
| # 3x2 (with higher order broadcasting) | |||
| ( | |||
| np.arange(36).reshape(6, 2, 3), | |||
| ) | |||
| ), | |||
| # ( | |||
There was a problem hiding this comment.
I forgot to remove these comments here and made another commit after this to remove this
There was a problem hiding this comment.
Yeah, I think that commit was lost, I made another one to fix it, thanks!
As title.
sklam
approved these changes
Oct 12, 2020
sklam
added
5 - Ready to merge
|
@rishabhvarshney14 finally, congrats are in order! Looks like this one made it just in the nick of time for the 0.52.0RC1 -- be on the lookout for a mention in the release notes! |
|
@sklam thanks for approval and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title: re-roll #6279 due to git issues.