Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option nogil=True not required for ufuncs and gufuncs #6445

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions numba/np/ufunc/ufuncbuilder.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import inspect
from contextlib import contextmanager
import warnings

from numba.core.decorators import jit
from numba.core.descriptors import TargetDescriptor
Expand Down Expand Up @@ -82,6 +83,10 @@ def compile(self, sig, locals={}, **targetoptions):
topt.update(targetoptions)

flags = compiler.Flags()
if 'nogil' in topt:
warnings.warn("nogil option is not required, ufuncs and gufuncs "
"always releases GIL for CPU target")
Comment on lines +87 to +88
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using numba.errors.NumbaWarning as the warning category such that it's easier for users to filter out things from Numba.

Comment on lines +87 to +88
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
warnings.warn("nogil option is not required, ufuncs and gufuncs "
"always releases GIL for CPU target")
warnings.warn("The 'nogil' option is not required, ufuncs and gufuncs "
"always release the GIL on the CPU target")

topt.pop('nogil')
self.targetdescr.options.parse_as_flags(flags, topt)

flags.set("no_cpython_wrapper")
Expand Down
18 changes: 18 additions & 0 deletions numba/tests/test_warnings.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from numba import jit
from numba.core.errors import NumbaWarning, deprecated, NumbaDeprecationWarning
from numba.core import errors
from numba import vectorize


class TestBuiltins(unittest.TestCase):
Expand Down Expand Up @@ -204,6 +205,23 @@ def test_disable_performance_warnings(self):
out, err = popen.communicate()
self.assertEqual(popen.returncode, not_found_ret_code)

def test_warning_vectorize_with_nogil(self):
@vectorize(nogil=True)
Comment on lines +208 to +209
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to check guvectorize as well given the error message mentions it?

def f(a, b):
return np.sqrt(a) + np.cos(b) * np.sin(b) - a

with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')

nelem = 10 ** 2
x = np.arange(nelem)
f(x, x)

self.assertEqual(w[0].category, UserWarning)
self.assertIn('nogil option is not required', str(w[0].message))
self.assertIn('ufuncs and gufuncs always releases GIL for CPU '
'target', str(w[0].message))


if __name__ == '__main__':
unittest.main()