fix abstract base class import #6486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/circleci/repo/fastparquet/fastparquet/__init__.py", line 5, in <module>
from .core import read_thrift
File "/home/circleci/repo/fastparquet/fastparquet/core.py", line 9, in <module>
from . import encoding
File "/home/circleci/repo/fastparquet/fastparquet/encoding.py", line 13, in <module>
import numba
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/__init__.py", line 39, in <module>
from numba.core.decorators import (cfunc, generated_jit, jit, njit, stencil,
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/core/decorators.py", line 12, in <module>
from numba.stencils.stencil import stencil
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/stencils/stencil.py", line 11, in <module>
from numba.core import types, typing, utils, ir, config, ir_utils, registry
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/core/registry.py", line 4, in <module>
from numba.core import utils, typing, dispatcher, cpu
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/core/dispatcher.py", line 15, in <module>
from numba.core import utils, types, errors, typing, serialize, config, compiler, sigutils
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/core/compiler.py", line 6, in <module>
from numba.core import (utils, errors, typing, interpreter, bytecode, postproc,
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/site-packages/numba/core/callconv.py", line 5, in <module>
from collections import namedtuple, Iterable
File "<frozen importlib._bootstrap>", line 1032, in _handle_fromlist
File "/home/circleci/repo/miniconda3/envs/fastparquet/lib/python3.7/collections/__init__.py", line 52, in __getattr__
DeprecationWarning, stacklevel=2)
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working```
|
Should probably go into 0.52.0rc3 as the change was introduced to deal with setting attrs on call from an iterable. |
stuartarchibald
approved these changes
Nov 16, 2020
stuartarchibald
added
5 - Ready to merge
sklam
added a commit
to sklam/numba
that referenced
this pull request
Nov 17, 2020
fix abstract base class import
Merged
stuartarchibald
added a commit
to stuartarchibald/numba
that referenced
this pull request
Nov 18, 2020
With view of catching issues like that fixed in numba#6486 as the entire code base is not yet run under flake8. Also fixes this test module and makes it flake8 compliant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was detected by the Fastparquet Numba integration testing.