Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor llvm replacement code into separate function #6567

Merged
merged 1 commit into from Jan 12, 2021
Merged

Refactor llvm replacement code into separate function #6567

merged 1 commit into from Jan 12, 2021

Conversation

testhound
Copy link
Contributor

This pull request is in response to: #6557. It refactors the llvm replacement code into a separate function.

@esc esc added 3 - Ready for Review CUDA CUDA related issue/PR labels Dec 11, 2020
@esc
Copy link
Member

esc commented Dec 11, 2020

@testhound thank you for submitting this, I have added it to the queue for review.

@stuartarchibald stuartarchibald added the Effort - short Short size effort needed label Dec 11, 2020
@stuartarchibald stuartarchibald added this to the PR Backlog milestone Dec 11, 2020
@stuartarchibald
Copy link
Contributor

@uchytilc does this cover what you were considering in #6557 ?

@uchytilc
Copy link

It's perfect!

@stuartarchibald
Copy link
Contributor

It's perfect!

Thanks for confirming.

stuartarchibald
stuartarchibald approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, changes look good.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm and removed 3 - Ready for Review labels Dec 17, 2020
@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_146.

@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_146.

Passed.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Jan 12, 2021
@sklam sklam merged commit 24764ad into numba:master Jan 12, 2021
@gmarkall gmarkall mentioned this pull request Mar 31, 2021
Closed
@testhound testhound deleted the testhound/refactor_llvm_replace branch June 1, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@gmarkall gmarkall Awaiting requested review from gmarkall

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.53 RC
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@testhound @esc @stuartarchibald @uchytilc @sklam