Adds tests for PR 5659 #6664
Merged
Adds tests for PR 5659 #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes some test to use the more descriptive assertEqual instead of assertTrue
sklam
added
Effort - short
DrTodd13
requested changes
Jan 27, 2021
numba/tests/test_parfors.py
Outdated
| src = cycle(gen()) | ||
| return [next(src) for i in range(ct)] | ||
|
|
||
| def gen_linespace_variants(self, ct): |
There was a problem hiding this comment.
Did you mean linespace or linspace?
There was a problem hiding this comment.
Thanks for writing these extra tests @sklam, looks good, just one dead comment to remove and then can be merged.
numba/parfors/parfor.py
Outdated
| @@ -1920,7 +1920,8 @@ def run(self, blocks): | |||
| if isinstance(instr, ir.Assign): | |||
| expr = instr.value | |||
| lhs = instr.target | |||
| if self._is_C_order(lhs.name): | |||
| lhs_typ = self.pass_states.typemap[lhs.name] | |||
| if self._is_C_or_F_order(lhs_typ): | |||
| # only translate C order since we can't allocate F | |||
There was a problem hiding this comment.
remove this comment?
There was a problem hiding this comment.
Yes, this comment should go.
stuartarchibald
added
4 - Waiting on author
DrTodd13
previously requested changes
Feb 3, 2021
numba/parfors/parfor.py
Outdated
| @@ -1920,7 +1920,8 @@ def run(self, blocks): | |||
| if isinstance(instr, ir.Assign): | |||
| expr = instr.value | |||
| lhs = instr.target | |||
| if self._is_C_order(lhs.name): | |||
| lhs_typ = self.pass_states.typemap[lhs.name] | |||
| if self._is_C_or_F_order(lhs_typ): | |||
| # only translate C order since we can't allocate F | |||
There was a problem hiding this comment.
Yes, this comment should go.
|
i've removed the dead comment |
sklam
added
4 - Waiting on reviewer
thanks. |
stuartarchibald
added
4 - Waiting on CI
stuartarchibald
approved these changes
Feb 3, 2021
stuartarchibald
removed
the
4 - Waiting on CI
stuartarchibald
added
the
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5659
Adds tests for 1D, 2D, 3D and C/F order arrays for parfors.
Note for reviewer: the main changes to the PR starts in 2628ec4.
The only file I touched in the
test_parfors.py.