Make NumPy random module use @overload_glue #7049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklam
reviewed
May 20, 2021
numba/cpython/randomimpl.py
Outdated
Comment on lines
1302
to
1303
| *mod, fname = typing_key.split('.') | ||
| np_func = getattr(np.random, fname) |
There was a problem hiding this comment.
mod is unused and np.random is hardcode in getattr. Maybe there should be a assert to make sure mod is np.random
There was a problem hiding this comment.
Good point, done in 332c999
sklam
added
4 - Waiting on author
As title. Responding to PR feedback.
stuartarchibald
added
4 - Waiting on reviewer
sklam
added
5 - Ready to merge
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.