Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NumPy random module use @overload_glue #7049

Merged
merged 2 commits into from May 24, 2021

Conversation

stuartarchibald
Copy link
Contributor

As title.

Comment on lines 1302 to 1303
*mod, fname = typing_key.split('.')
np_func = getattr(np.random, fname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod is unused and np.random is hardcode in getattr. Maybe there should be a assert to make sure mod is np.random

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done in 332c999

@sklam sklam added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels May 20, 2021
As title. Responding to PR feedback.
@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author Effort - medium Medium size effort needed and removed 4 - Waiting on author Waiting for author to respond to review labels May 21, 2021
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels May 24, 2021
@sklam sklam merged commit d897126 into numba:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - medium Medium size effort needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants