Adding implementation of isinstance. #7204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the starter patch @DrTodd13, @guilhermeleobas is taking a look at how to extend this etc, thanks @guilhermeleobas! |
2 tasks
|
@guilhermeleobas implemented this fully in #7244, closing as complete. Thanks again for the initial ideas @DrTodd13. |
stuartarchibald
added
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only checked this for simple cases to get the discussion rolling.
We need to think of cases that we think might break it and even if it doesn't then that is the set of things we can test for.
Both individual and tuples of types are supported.