Fixes issue reported under #7217 #7228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with ``literal_unroll`` reported in numba#7217. Does not close the issue as there's potentially more than just this problem with ``literal_unroll`` present. This patch adds a fix to update the scope of blocks in the versioned loop bodies with variables that have been versioned.
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
NOTE: AZP is maybe having some issues. Have had to request reruns/close-open PR. Deleted comments from |
sklam
reviewed
Jul 22, 2021
Comment on lines
+914
to
+922
| new_var_table = get_name_var_table(loop_blocks) | ||
| for blk in loop_blocks.values(): | ||
| scope = blk.scope | ||
| real_con = scope.localvars._con | ||
| for name, var in dict(scope.localvars._con).items(): | ||
| if name in new_var_dict: | ||
| new_name = new_var_dict[name] | ||
| del real_con[name] | ||
| real_con[new_name] = new_var_table[new_name] |
There was a problem hiding this comment.
I probably will make a follow up PR to refactor it with ir_utils.fixup_var_define_in_scope
There was a problem hiding this comment.
Thanks. I think the issue is that the versioned loop bodied have versions of some of the original variables and potentially replace the original.
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sklam
added
4 - Waiting on reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with
literal_unrollreported in #7217.Does not close the issue as there's potentially more than just
this problem with
literal_unrollpresent.This patch adds a fix to update the scope of blocks in the
versioned loop bodies with variables that have been versioned.