Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7507. catch NotImplementedError in .get_function() #7580

Merged
merged 1 commit into from Nov 24, 2021
Merged

Fix #7507. catch NotImplementedError in .get_function() #7580

merged 1 commit into from Nov 24, 2021

Conversation

sklam
Copy link
Member

@sklam sklam commented Nov 18, 2021

Exception handler should be catching NotImplementedError instead.

Reference an existing issue

@sklam sklam marked this pull request as ready for review November 18, 2021 20:30
@sklam sklam added this to the Numba 0.55 RC milestone Nov 19, 2021
@stuartarchibald stuartarchibald added the Effort - medium Medium size effort needed label Nov 22, 2021
@stuartarchibald stuartarchibald self-assigned this Nov 22, 2021
@stuartarchibald
Copy link
Contributor

CC @guilhermeleobas Does this fix the issue you were seeing a few weeks back? xref: #7507

@stuartarchibald
Copy link
Contributor

Local testing of MWR in #7507 (comment) confirms this patch fixes that particular issue.

stuartarchibald
stuartarchibald approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this @sklam, patch and test (which is based on the MWR) look good. Waiting on @guilhermeleobas to confirm against RBC (thanks in advance for testing!).

@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review labels Nov 22, 2021
@guilhermeleobas
Copy link
Collaborator

I can confirm this change fix the issue I faced in RBC.

@stuartarchibald
Copy link
Contributor

I can confirm this change fix the issue I faced in RBC.

Great, thanks for checking @guilhermeleobas, much appreciated!

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Nov 23, 2021
@sklam sklam merged commit 714c0c4 into numba:master Nov 24, 2021
@sklam sklam deleted the fix/iss7507 branch November 24, 2021 00:04
@gmarkall gmarkall mentioned this pull request Jun 21, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@esc esc Awaiting requested review from esc

Assignees

@stuartarchibald stuartarchibald

Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - medium Medium size effort needed
Projects
None yet
Milestone
Numba 0.55 RC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sklam @stuartarchibald @guilhermeleobas