Add support for casting from int enums #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testhound
requested review from
esc,
sklam and
stuartarchibald
as code owners
|
gpuci run tests |
|
Can you add a test for the failing case please? |
stuartarchibald
added
4 - Waiting on author
|
For the location of the test, it could go in |
stuartarchibald
added
4 - Waiting on reviewer
gmarkall
requested changes
Nov 25, 2021
There was a problem hiding this comment.
Thanks for adding the tests. I suggested some changes because there's already a test testing implicit coercion, so the uses of the IntEnum in this new case might as well all be casts - I suggested adding different types to cast to as well to ensure that casting to different widths also works.
numba/tests/test_enums.py
Outdated
| @@ -50,6 +50,13 @@ def int_coerce_usecase(x): | |||
| else: | |||
| return x + Shape.circle | |||
|
|
|||
| def int_cast_usecase(x): | |||
| # Implicit coercion of intenums to ints | |||
There was a problem hiding this comment.
Suggested change
| # Implicit coercion of intenums to ints | |
| # Explicit casting of intenums to ints |
numba/tests/test_enums.py
Outdated
| if x > RequestError.internal_error: | ||
| return x - RequestError.not_found | ||
| else: | ||
| return x + int32 (Shape.circle) |
There was a problem hiding this comment.
Suggested change
| return x + int32 (Shape.circle) | |
| return x + int8(Shape.circle) |
numba/tests/test_enums.py
Outdated
Comment on lines
55
to
56
| if x > RequestError.internal_error: | ||
| return x - RequestError.not_found |
There was a problem hiding this comment.
Suggested change
| if x > RequestError.internal_error: | |
| return x - RequestError.not_found | |
| if x > int16(RequestError.internal_error): | |
| return x - int32(RequestError.not_found) |
numba/tests/test_enums.py
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| import numpy as np | |||
| import unittest | |||
| from numba import jit, vectorize | |||
| from numba import jit, vectorize, int32 | |||
There was a problem hiding this comment.
Suggested change
| from numba import jit, vectorize, int32 | |
| from numba import jit, vectorize, int8, int16, int32 |
gmarkall
added
4 - Waiting on author
|
gpuci run tests |
gmarkall
approved these changes
Nov 29, 2021
gmarkall
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a enum to int cast problem documented in this issue: #7573 and introduced here: f2311d2.
Fixes #7573