Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid issue with DI gen for arrayexprs. #7788

Merged
merged 1 commit into from Jan 26, 2022
Merged

Avoid issue with DI gen for arrayexprs. #7788

merged 1 commit into from Jan 26, 2022

Conversation

stuartarchibald
Copy link
Contributor

As title. Alters a test looking for breakpoints on lines that uses
arrayexprs to not use arrayexprs as #7752 leads to the arrayexpr
referencing the source line repeatedly.

Fixes #7787

@stuartarchibald
Avoid issue with DI gen for arrayexprs.
ce84d2a 
As title. Alters a test looking for breakpoints on lines that uses
arrayexprs to not use arrayexprs as numba#7752 leads to the arrayexpr
referencing the source line repeatedly.

Fixes numba#7787
@stuartarchibald stuartarchibald mentioned this pull request Jan 26, 2022
Merged
@stuartarchibald stuartarchibald added this to the Numba 0.55.1 milestone Jan 26, 2022
@stuartarchibald
Copy link
Contributor Author

Am putting this into 0.55.1 (https://github.com/numba/numba/milestone/62). #7752 is in 0.55.1 and this fixes the problem caused by #7752 as reported in #7787.

@stuartarchibald
Copy link
Contributor Author

Seems to be ok now: https://dev.azure.com/numba/ff1fe4d0-ed73-4f1c-b894-1d50a27e048f/_apis/build/builds/10911/logs/78

Note the:

(numba.tests.test_gdb_dwarf.TestGDBDwarf) ... ok
2022-01-26T12:47:43.3256589Z test_array_arg

in the details:

Details: 
2022-01-26T12:47:31.0132118Z # Now run tests based on the changes identified via git
2022-01-26T12:47:31.0133611Z NUMBA_ENABLE_CUDASIM=1 $SEGVCATCH python -m numba.runtests -b -v -g -m $TEST_NPROCS -- numba.tests
2022-01-26T12:47:33.4847832Z Git diff identified 5 tests
2022-01-26T12:47:33.4849256Z Parallel: 5. Serial: 0
2022-01-26T12:47:33.4997556Z test (numba.tests.gdb.test_array_arg.Test) ... skipped 'needs subprocess harness'
2022-01-26T12:47:42.7649721Z test_basic (numba.tests.test_gdb_dwarf.TestGDBDwarf) ... ok
2022-01-26T12:47:43.3256589Z test_array_arg (numba.tests.test_gdb_dwarf.TestGDBDwarf) ... ok
2022-01-26T12:47:52.0595187Z test_conditional_breakpoint (numba.tests.test_gdb_dwarf.TestGDBDwarf) ... ok
2022-01-26T12:47:58.7994477Z test_break_on_symbol (numba.tests.test_gdb_dwarf.TestGDBDwarf) ... ok

esc
esc approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-01-26 at 14 04 36

Looks good from here too.

@esc esc added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Jan 26, 2022
@stuartarchibald stuartarchibald merged commit 324dd8f into numba:master Jan 26, 2022
esc pushed a commit to esc/numba that referenced this pull request Jan 26, 2022
@stuartarchibald @esc
Merge pull request numba#7788 from stuartarchibald/fix/failing_debug_…
0a4e6c9 
…line_test

Avoid issue with DI gen for arrayexprs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esc esc esc approved these changes

@sklam sklam Awaiting requested review from sklam

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.55.1
Development

Successfully merging this pull request may close these issues.

arrayexpr file/line association in DI causing test to fail
2 participants
@stuartarchibald @esc