Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change time.time() to time.perf_counter() in docs #7845

Merged
merged 1 commit into from Feb 18, 2022
Merged

change time.time() to time.perf_counter() in docs #7845

merged 1 commit into from Feb 18, 2022

Conversation

Nopileos2
Copy link
Contributor

Minor changes to the 5 minute guide:

  • time.perf_counter() is preferred way to measure execution time, so best to use it here since it is exactly what should be done
  • changed style of string formatting and added 's' as the unit

@Nopileos2
change time.time() to time.perf_counter() in docs
7dc11d3 
* time.perf_counter() is preferred way to measure execution time
* changed style of string formatting and added 's' as the unit
@gmarkall gmarkall added this to the Numba 0.56 RC milestone Feb 15, 2022
@gmarkall
Copy link
Member

Many thanks for the PR - I've queued it for review.

stuartarchibald
stuartarchibald approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, good to keep these examples in sync with common practice.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Feb 18, 2022
@sklam sklam merged commit 290bcaa into numba:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@sklam sklam Awaiting requested review from sklam

@esc esc Awaiting requested review from esc

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge doc Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.56 RC
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nopileos2 @gmarkall @stuartarchibald @sklam