New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: support numpy array comparison with string #8104

Closed

dlee992 wants to merge 1 commit into numba:main from dlee992:array_cmp_with_string

Contributor

dlee992 commented May 24, 2022 •

edited

fix #7859 .

Choose an alternative to implement this feature:

Aligned with NumPy, use special case to handle string ufunc (I don't want to choose this way, because I guess this makes string case cannot use ufunc-related optimization?)
Pending on NumPy new version (1.23?), then use an unified way to handle all ufuncs
- tested on NumPy==1.23.0rc2, it doesn't unify string case and others. [2022-6-6]

Updates on 2022-6-21:

I choose to help NumPy to complete the string ufunc unification PRs.
Then back to Numba string ufuncs.


          add test case

dlee992 requested review from sklam, stuartarchibald and esc as code owners

May 24, 2022 07:56

dlee992 marked this pull request as draft

May 24, 2022 07:56

stuartarchibald added the 2 - In Progress label

dlee992 mentioned this pull request

ENH: Implement string comparison ufuncs (or almost) numpy/numpy#21041

Merged

Contributor Author

dlee992 commented Nov 21, 2022

Indeed, I didn't follow this thread these days. So I guess I should just close it.

dlee992 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment