Shorten the time to verify test discovery. #8427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Numba project uses `python -m numba.tests.test_runtests` in build scripts to verify that test discovery and the test suite itself is working as expected. This is a guard to make sure that when the test suite is run, it's actually running what is expected. This patch tries to shorten the time it takes to get to the point of the test suite being validated. It does two things: 1. Hoists a costly loop invariant from a loop in one of the tests in the test_runtests module. 2. Caches the mtime of test files based on class as this should be invariant (gains about 3-4% improvement on runtests.py -l).
stuartarchibald
added
3 - Ready for Review
Effort - short
apmasell
approved these changes
Sep 13, 2022
stuartarchibald
added
4 - Waiting on second reviewer
esc
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
I did a crude benchmark of this branch with main.
For main I get the following times: 70.326s and 69.016s and 64.027s.
For the feature branch I get: 62.353s and 54.295s and 55.061s.
This is sufficient evidence for me regarding the effect this change has, thank you for the patch!
esc
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Numba project uses
python -m numba.tests.test_runtestsin build scripts to verify that test discovery and the test suite itself is working as expected. This is a guard to make sure that when the test suite is run, it's actually running what is expected.This patch tries to shorten the time it takes to get to the point of the test suite being validated. It does two things: