Fix objectmode is/is not #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. |
| return self.builder.call(fn, (lhs, rhs, lopid)) | ||
| if opstr in ops: | ||
| opid = ops.index(opstr) | ||
| assert 0 <= opid < len(ops) |
There was a problem hiding this comment.
That assert is really pointless, IMHO.
|
Has this already been released? |
|
Given this was merged in 2014, yes, it's already been released in quite a few releases. |
|
@pitrou Thanks. It's kindda difficult to know what release to attribute each pull request to, unless you decided to use the 'Milestone' feature... ;-) |
|
For that, I recommend you use the release notes, which tend to be documented quite comprehensively: |
|
@pitrou much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User reported the error https://groups.google.com/a/continuum.io/forum/?utm_medium=email&utm_source=footer#!msg/numba-users/3KwP6FVakBs/NawO3DcJqHMJ
Reason:
isandis notwere not handled in object mode.