Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix objectmode is/is not #857

Merged
merged 2 commits into from Nov 24, 2014
Merged

Fix objectmode is/is not #857

merged 2 commits into from Nov 24, 2014

Conversation

@sklam
Copy link
Contributor

@sklam sklam commented Nov 11, 2014

@gmarkall
Copy link
Member

@gmarkall gmarkall commented Nov 12, 2014

This looks good to me.

return self.builder.call(fn, (lhs, rhs, lopid))
if opstr in ops:
opid = ops.index(opstr)
assert 0 <= opid < len(ops)

This comment has been minimized.

@pitrou

pitrou Nov 13, 2014
Contributor

That assert is really pointless, IMHO.

pitrou added a commit that referenced this pull request Nov 24, 2014
Fix objectmode is/is not
@pitrou pitrou merged commit 6bdd982 into numba:master Nov 24, 2014
1 check passed
1 check passed
@sklam
continuous-integration/travis-ci The Travis CI build passed
Details
@InonS
Copy link

@InonS InonS commented Jan 30, 2016

Has this already been released?
These things make a difference in our productivity (see my comment on #504).

@pitrou
Copy link
Contributor

@pitrou pitrou commented Jan 31, 2016

Given this was merged in 2014, yes, it's already been released in quite a few releases.

@InonS
Copy link

@InonS InonS commented Jan 31, 2016

@pitrou Thanks. It's kindda difficult to know what release to attribute each pull request to, unless you decided to use the 'Milestone' feature... ;-)

@pitrou
Copy link
Contributor

@pitrou pitrou commented Jan 31, 2016

For that, I recommend you use the release notes, which tend to be documented quite comprehensively:
http://numba.pydata.org/numba-doc/dev/release-notes.html

@InonS
Copy link

@InonS InonS commented Jan 31, 2016

@pitrou much appreciated!

@sklam sklam deleted the sklam:fix_objmode_is_not branch Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants