Throw error for unsupported dunder methods #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Make jitclass throw an error rather than ignore unhandled `__X__` methods.
| if ( | ||
| name.startswith("__") | ||
| and name.endswith("__") | ||
| and name not in supported_dunders | ||
| ): | ||
| continue | ||
| raise TypeError("Method {0} is not supported".format(name)) |
There was a problem hiding this comment.
Suggest adding a unit test that checks this error message is raised as expected to numba.tests.test_jitclasses.
stuartarchibald
added
4 - Waiting on author
Ensure forbidden dunder methods are not created.
apmasell
added
3 - Ready for Review
and removed
4 - Waiting on author
There was a problem hiding this comment.
@apmasell many thanks for adding the test. Couple of minor things to resolve else looks good.
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
stuartarchibald
approved these changes
Nov 18, 2022
stuartarchibald
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make jitclass throw an error rather than ignore unhandled
__X__methods.