Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bare reraise support #8644

Merged
merged 1 commit into from Dec 6, 2022
Merged

Fix bare reraise support #8644

merged 1 commit into from Dec 6, 2022

Conversation

sklam
Copy link
Member

@sklam sklam commented Dec 6, 2022

  • restore lost logic that we only ban reraise within a try-except block, but bare reraise (causes the interpreter to reraise existing exception value) is supported.
  • fix C logic in handling reraise. C API changed and old code needs access to now opaque struct (_PyErr_StackItem). Use PyErr_GetExcInfo instead.

@sklam sklam added 2 - In Progress Python 3.11 All issues related to Python 3.11 support labels Dec 6, 2022
stuartarchibald
stuartarchibald approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, the changes seem appropriate given what is being fixed. The two tests failing on Python 3.11 related to reraise now pass!

@sklam sklam marked this pull request as ready for review December 6, 2022 15:22
@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Dec 6, 2022
@stuartarchibald stuartarchibald added this to the Numba 0.57 RC milestone Dec 6, 2022
@sklam sklam merged commit 9713453 into numba:py3.11 Dec 6, 2022
@sklam sklam deleted the fix/py311_reraise branch December 7, 2022 17:55
@stuartarchibald stuartarchibald mentioned this pull request Jan 25, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge Python 3.11 All issues related to Python 3.11 support
Projects
None yet
Milestone
Numba 0.57 RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sklam @stuartarchibald