Fix #8903. NumbaDeprecationWarnings raised from @{gu,}vectorize.
#8909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze`.
This adds localised suppressions for `NumbaDeprecationWarning`s that
would have been raised from the code path for `@{gu,}vectorize` due to
Numba's internal use of `@jit()` with the `nopython` kwarg not present.
This is considered acceptable due to the following: Deprecation warnings
from Numba's internal use of its own API should not be visible to users.
Unfortunately there's no trivial programmatic way to work around the
internal use of `@jit`-with-no-kwargs in this case as numerous code
paths go through the same operations and user code may well be relying on
"object mode" fall-back. What this patch does it makes it so that users will
not see `NumbaDeprecationWarning`s for this internal use. However, if a
user defines a `@{gu,}vectorize` function that ends up using the fall-back
to the object mode pipeline during compilation, Numba will continue to raise
numerous loud warnings about this happening which should provide a hint as
to the problem and how to fix it.
Numerous tests have been added to check combinations of kwargs/use of
default kwargs being passed through to `@{gu,}vectorize`. These tests
make sure that there are no additional `NumbaDeprecationWarning`s
raised to do with Numba's internal use of `@jit()` in `@{gu,}vectorize`
where the `nopython` kwarg is not supplied.
Closes numba#8903
|
Note that 0d1969a fixes |
stuartarchibald
added
3 - Ready for Review
Effort - medium
sklam
approved these changes
Apr 24, 2023
sklam
added
5 - Ready to merge
This was referenced Apr 25, 2023
Closed
sklam
added a commit
to sklam/numba
that referenced
this pull request
Apr 25, 2023
Fix numba#8903. `NumbaDeprecationWarning`s raised from `@{gu,}vectorize`.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds localised suppressions for
NumbaDeprecationWarnings that would have been raised from the code path for@{gu,}vectorizedue to Numba's internal use of@jit()with thenopythonkwarg not present.This is considered acceptable due to the following: Deprecation warnings from Numba's internal use of its own API should not be visible to users. Unfortunately there's no trivial programmatic way to work around the internal use of
@jit-with-no-kwargs in this case as numerous code paths go through the same operations and user code may well be relying on "object mode" fall-back. What this patch does it makes it so that users will not seeNumbaDeprecationWarnings for this internal use. However, if a user defines a@{gu,}vectorizefunction that ends up using the fall-back to the object mode pipeline during compilation, Numba will continue to raise numerous loud warnings about this happening which should provide a hint as to the problem and how to fix it.Numerous tests have been added to check combinations of kwargs/use of default kwargs being passed through to
@{gu,}vectorize. These tests make sure that there are no additionalNumbaDeprecationWarnings raised to do with Numba's internal use of@jit()in@{gu,}vectorizewhere thenopythonkwarg is not supplied.Closes #8903