NumPy 1.25 support (PR #9011) continued #9105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy 1.25 has two major changes: - allow mixed signed comparisons ufuncs (the `qQ->?` and `Qq->?` implementations for `>`, `<`, `>=`, `<=`, `==`, `!=`); this mode was not supported by Numba and an appropriate implementation is added to match the C implementation in NumPy. - the implementation of `sin` and `cos` are changed in a way that produces slightly different numeric results. This either lowers the comparison precision where these functions are used in tests or replaces them with another function (mostly `exp`) to avoid the differences.
Changes the implementations to use `select` rather than a branching path for better optimization potential.
The corresponding change was removed from NumPy 1.25 so any numeric changes for sin/cos are also being reverted.
As titled.
Switch `numpy.core.umath_tests.matrix_multiply`, which is private API, with `numpy.matmul`, which is public.
As titled
As titled.
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
As titled.
As titled.
As titled.
This function has been renamed in 1.25
These use to be the same implementation, so only one was binding was required, but now that they are deprecated, separate bindings necessary as the implementations are split to trigger warnings.
As titled.
As titled.
As requested in review.
NumPy 1.25 packages are not provided for Python < 3.10 on the default conda channel, so we need to use a newer version.
There isn't a suitable RAPIDS image with 3.10 that keeps the versions of all other components the same, so instead we'll keep the 3.8 image and create a 3.10 environment in it.
As titled.
This reverts commit 1a1c7c1. Reverted as this should not be required, as per discussion on https://github.com/numba/numba/pull/9011/files#r1261153152
|
gpuci run tests |
|
I just noticed we're only going up to NumPy 1.24 for Azure CI on Windows and macOS, which seems like an oversight. Going to update this to 1.25 and re-run CI. |
|
gpuci run tests |
|
gpuci run tests |
esc
added
4 - Waiting on CI
|
This passed on our build farm as |
esc
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues PR #9011, which has been closed as the original author is no longer working on it. The branch for this PR is the same as it was on #9011, with the
test_parfors.pychange reverted as requested in https://github.com/numba/numba/pull/9011/files#r1261153152.