New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conda-recipe for numba-rvsdg #9120
Update conda-recipe for numba-rvsdg #9120
Conversation
Next release will be 0.1.
3ee03cd
to
4b56f78
Compare
Rebase and force pushed so we have a simpler history. |
@@ -63,6 +63,8 @@ requirements: | |||
- scipy >=1.0 | |||
# CUDA Python 11.6 or later | |||
- cuda-python >=11.6 | |||
# numba-rvsdg | |||
- numba-rvsdg 0.0.* # [py==311] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we don't pin to any specific version so that we have rooms to fix stuff without needing to re-release. Also, this is just a test run for the dependency. Only bleeding-edge developers will be using numba-rvsdg
and they can manually pin versions if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we should pin to 0.0.5
once it's released via numba/numba-rvsdg#105. But perhaps just leaving it open is a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kc611 and I pair reviewed this using the following procedure:
- build the package based on the recipe
- install package in test environment
- run NUMBA_USE_RVSDG_FRONTEND=1 python frontend-test.py to observe the guard being triggered
- install
-c numba numba-rvsdg
- run NUMBA_USE_RVSDG_FRONTEND=1 python frontend-test.py and observe it succeed
from numba import njit
@njit
def sum(a):
c = 0
for i in range(7):
c += i
return c
print(sum(7))
Update conda-recipe for numba-rvsdg
Base on #9012.
Depends on numba/numba-rvsdg#91.