Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda-recipe for numba-rvsdg #9120

Merged
merged 3 commits into from Aug 15, 2023

Conversation

sklam
Copy link
Member

@sklam sklam commented Aug 4, 2023

Base on #9012.
Depends on numba/numba-rvsdg#91.

  • 80eb150 adds runtime constraints for numba-rvsdg.
  • 1b19c22 adds import guard and direct user to install numba-rvsdg when the rvsdg-frontend subpackage is used.

@sklam sklam changed the title Enh/py311rvsdg buildscript Update conda-recipe for numba-rvsdg Aug 4, 2023
@esc esc added this to the Numba 0.58 RC milestone Aug 9, 2023
@sklam sklam force-pushed the enh/py311rvsdg_buildscript branch from 3ee03cd to 4b56f78 Compare August 10, 2023 15:50
@sklam sklam added the skip_release_notes Skip towncrier requirement label Aug 10, 2023
@sklam sklam closed this Aug 10, 2023
@sklam sklam reopened this Aug 10, 2023
@sklam
Copy link
Member Author

sklam commented Aug 10, 2023

Rebase and force pushed so we have a simpler history.

@@ -63,6 +63,8 @@ requirements:
- scipy >=1.0
# CUDA Python 11.6 or later
- cuda-python >=11.6
# numba-rvsdg
- numba-rvsdg 0.0.* # [py==311]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we don't pin to any specific version so that we have rooms to fix stuff without needing to re-release. Also, this is just a test run for the dependency. Only bleeding-edge developers will be using numba-rvsdg and they can manually pin versions if needed.

Copy link
Member

@esc esc Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we should pin to 0.0.5 once it's released via numba/numba-rvsdg#105. But perhaps just leaving it open is a better idea.

Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kc611 and I pair reviewed this using the following procedure:

  • build the package based on the recipe
  • install package in test environment
  • run NUMBA_USE_RVSDG_FRONTEND=1 python frontend-test.py to observe the guard being triggered
  • install -c numba numba-rvsdg
  • run NUMBA_USE_RVSDG_FRONTEND=1 python frontend-test.py and observe it succeed
from numba import njit


@njit
def sum(a):
    c = 0
    for i in range(7):
        c += i
    return c


print(sum(7))

@esc esc added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Aug 15, 2023
@esc esc merged commit e4ec15a into numba:feature/rvsdg_frontend Aug 15, 2023
4 of 5 checks passed
esc added a commit to sklam/numba that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge skip_release_notes Skip towncrier requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants