Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix numpy version #9208

Closed
wants to merge 1 commit into from
Closed

fix numpy version #9208

wants to merge 1 commit into from

Conversation

Tialo
Copy link
Contributor

@Tialo Tialo commented Sep 22, 2023

For some reason numpy version for numba installation is not fixated for >=1.22. Thus, you can install Numba==0.58 and numpy<1.22. Which after import numba results in exception https://github.com/numba/numba/blob/main/numba/__init__.py#L37

installation

pip install numba "numpy<1.22"

exception

import numba

@esc
Copy link
Member

esc commented Sep 25, 2023

@Tialo thank you for reporting this. It seems like there are some inconsistencies here. The version support table for 0.58 actually lists 1.21 as being the minimum supported version:

https://numba.readthedocs.io/en/0.58.0/user/installing.html#version-support-information

Screenshot 2023-09-25 at 11 56 06

I will investigate this some, thank you for the report.

@A-CGray
Copy link

A-CGray commented Sep 26, 2023

@Tialo thank you for reporting this. It seems like there are some inconsistencies here. The version support table for 0.58 actually lists 1.21 as being the minimum supported version:

https://numba.readthedocs.io/en/0.58.0/user/installing.html#version-support-information
Screenshot 2023-09-25 at 11 56 06

I will investigate this some, thank you for the report.

Presumably this PR should also update this table then?

@Tialo
Copy link
Contributor Author

Tialo commented Sep 26, 2023

I can do this, if necessary.

@sklam sklam added this to the 0.58.1-rc1 milestone Sep 26, 2023
@esc
Copy link
Member

esc commented Sep 26, 2023

I can do this, if necessary.

Yes, that would be good, thank you!

@Tialo
Copy link
Contributor Author

Tialo commented Sep 26, 2023

As you can see in my commit there was no release date in this table on master branch I added it.

@esc
Copy link
Member

esc commented Sep 26, 2023

As you can see in my commit there was no release date in this table on master branch I added it.

@Tialo yes, I think this PR will need a rebase once https://github.com/numba/numba/pull/9205/files is in main.

@Tialo
Copy link
Contributor Author

Tialo commented Sep 26, 2023

Okay, will do it

@esc
Copy link
Member

esc commented Sep 26, 2023

@Tialo excellent, thank you! I am hoping that #9205 will be merged soon, our CI system is currently being used for something else, so merges are on hold for the time being. I expect this to resolve within the next week or maybe two. As soon as that happens you can rebase this PR and the change of the release date should no longer be necessary on this PR.

@esc
Copy link
Member

esc commented Sep 28, 2023

@Tialo ok, the merge happened last night, can you now please rebase this, thank you!

@Tialo
Copy link
Contributor Author

Tialo commented Sep 28, 2023

Here you go @esc

@esc esc added 5 - Ready to merge Review and testing done, is ready to merge bug - build/packaging Bugs: issue with building or packaging Numba numpy and removed 3 - Ready for Review labels Sep 28, 2023
@esc
Copy link
Member

esc commented Sep 28, 2023

Here you go @esc

awesome, thank you!

@esc
Copy link
Member

esc commented Oct 11, 2023

This was cherry-picked into #9227 🍒 --so closing this one now.

@esc esc closed this Oct 11, 2023
@Tialo Tialo deleted the numpy-version branch October 11, 2023 21:52
@Tialo
Copy link
Contributor Author

Tialo commented Oct 11, 2023

Am I right, this PR will take effect in numba 0.58.1? @esc

@esc
Copy link
Member

esc commented Oct 12, 2023

Am I right, this PR will take effect in numba 0.58.1? @esc

Yes, I am planning to get that released, the checklist should appear soon. The closed issues in the milestone are the PRs that will need a backport to release058 branch. We usually create a PR targeting the release branch and cherry-pick the needed PRs one at a time from their merge-commit to main.

https://github.com/numba/numba/milestone/76?closed=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge bug - build/packaging Bugs: issue with building or packaging Numba numpy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants