New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix numpy version #9208
fix numpy version #9208
Conversation
aa861cc
to
410288f
Compare
@Tialo thank you for reporting this. It seems like there are some inconsistencies here. The version support table for 0.58 actually lists https://numba.readthedocs.io/en/0.58.0/user/installing.html#version-support-information I will investigate this some, thank you for the report. |
Presumably this PR should also update this table then? |
I can do this, if necessary. |
Yes, that would be good, thank you! |
As you can see in my commit there was no release date in this table on master branch I added it. |
@Tialo yes, I think this PR will need a rebase once https://github.com/numba/numba/pull/9205/files is in |
Okay, will do it |
@Tialo excellent, thank you! I am hoping that #9205 will be merged soon, our CI system is currently being used for something else, so merges are on hold for the time being. I expect this to resolve within the next week or maybe two. As soon as that happens you can rebase this PR and the change of the release date should no longer be necessary on this PR. |
@Tialo ok, the merge happened last night, can you now please rebase this, thank you! |
79f7ea1
to
14cf788
Compare
Here you go @esc |
awesome, thank you! |
This was cherry-picked into #9227 🍒 --so closing this one now. |
Am I right, this PR will take effect in numba 0.58.1? @esc |
Yes, I am planning to get that released, the checklist should appear soon. The closed issues in the milestone are the PRs that will need a backport to |
For some reason numpy version for numba installation is not fixated for >=1.22. Thus, you can install Numba==0.58 and numpy<1.22. Which after
import numba
results in exception https://github.com/numba/numba/blob/main/numba/__init__.py#L37installation
pip install numba "numpy<1.22"
exception