Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU CI: Test with Python 3.9-3.12 #9318

Merged
merged 4 commits into from Dec 6, 2023
Merged

GPU CI: Test with Python 3.9-3.12 #9318

merged 4 commits into from Dec 6, 2023

Conversation

gmarkall
Copy link
Member

@gmarkall gmarkall commented Nov 30, 2023

Now that Python 3.12 support is merged, this PR runs CUDA tests with Python versions 3.9 - 3.12 on gpuCI. A couple of other changes are required to support this:

  • I built new cubinlinker packages for Python 3.12. These have to come from the rapidsai-nightly conda channel at present. Once they have proven to be stable for a few days, they will be moved to the rapidsai channel and I will create a new PR here so that cubinlinker comes from the rapidsai channel again.
  • CUDA Python is now obtained from conda-forge, as it is a better source for CUDA packages than the NVIDIA channel - in particular the latest version on conda-forge supports up to Python 3.12.

@gmarkall
Copy link
Member Author

gpuci run tests

@gmarkall
Copy link
Member Author

gpuci run tests

@gmarkall gmarkall added the skip_release_notes Skip towncrier requirement label Nov 30, 2023
@gmarkall gmarkall closed this Nov 30, 2023
@gmarkall gmarkall reopened this Nov 30, 2023
@gmarkall
Copy link
Member Author

gpuci run tests

@gmarkall gmarkall added CUDA CUDA related issue/PR Effort - short Short size effort needed labels Nov 30, 2023
@gmarkall gmarkall changed the title [WIP] Test with multiple Python versions on gpuCI GPU CI: Test with Python 3.9-3.12 Nov 30, 2023
@gmarkall gmarkall marked this pull request as ready for review November 30, 2023 12:55
@gmarkall
Copy link
Member Author

gpuci run tests

1 similar comment
@gmarkall
Copy link
Member Author

gmarkall commented Dec 1, 2023

gpuci run tests

@gmarkall
Copy link
Member Author

gmarkall commented Dec 1, 2023

gpuCI is having an issue at the moment, so I'll mark this as "Pending CI" for a reminder for the time being.

@gmarkall gmarkall added 4 - Waiting on CI Review etc done, waiting for CI to finish 3 - Ready for Review and removed 3 - Ready for Review labels Dec 1, 2023
@gmarkall
Copy link
Member Author

gmarkall commented Dec 5, 2023

gpuci run tests

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. It's good to see gpuCI testing multiple Python versions now. I've left a comment inline that captures the outcome of the discussion regarding the change to using the rapidsai-nightly channel to obtain the cubinlinker package, no action is required. Thanks again!

"cudatoolkit=${CUDA_TOOLKIT_VER}" \
"rapidsai::cubinlinker" \
"rapidsai-nightly::cubinlinker" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following discussion at the triage meeting on 2023-12-05, it was decided that testing against nightly would be a good idea in general and so this change is going to remain.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review 4 - Waiting on CI Review etc done, waiting for CI to finish labels Dec 6, 2023
@sklam sklam merged commit 26867b1 into numba:main Dec 6, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge CUDA CUDA related issue/PR Effort - short Short size effort needed skip_release_notes Skip towncrier requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants