New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test isolation for stateful configurations in the testsuite #9403
Conversation
I have confirmed that it passes with conda-forge |
@sklam suggest changing the PR title to something like "Fix test isolation for stateful configurations" or something like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @sklam. I checked the test suite for uses of override_env_config
where an overridden env var is likely to impact machine code generation, it seems like this patch isolates all remaining cases which weren't already covered. As noted OOB there's still a potential issue with the use of the fast
flag, but this is better resolved through fixing #7168. There's one minor comment to resolve else looks good. Thanks again!
numba/tests/test_parfors.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: l4604 of this file has overrides.append(override_env_config(k, v))
which, by virtue of its use, is also creating skylake ISA specific machine code, however, all the tests in this test class are in subprocesses so it is "safe".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it needed the run_in_subprocess
for all test methods or else it fail: https://dev.azure.com/numba/numba/_build/results?buildId=16609&view=logs&j=7d262216-4420-5164-53df-7079f36c65da&t=9212e158-8292-5264-48bf-03dbdfc6e73f&l=712
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. This is approved conditional on CI passing once main
is stable again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve following merge of main
into this branch.
Fix test isolation for stateful configurations in the testsuite
This fixes a SIGILL detected in conda-forge/numba-feedstock#131 by adding needed isolation to test that changes the target machine.
Minimal reproducer is: