Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release task for 0.59.1 #9502

Merged
merged 7 commits into from Mar 22, 2024
Merged

Post release task for 0.59.1 #9502

merged 7 commits into from Mar 22, 2024

Conversation

sklam
Copy link
Member

@sklam sklam commented Mar 19, 2024

  • cherrypick change-log, remove old towncrier
  • cherrypick CI fixes on release branch
  • fix towncrier_check.py script

Post-merge:

@sklam sklam added the skip_release_notes Skip towncrier requirement label Mar 19, 2024
@sklam sklam force-pushed the misc/postrel0591 branch 2 times, most recently from fb7361a to 63164d5 Compare March 19, 2024 15:28
@sklam sklam mentioned this pull request Mar 19, 2024
30 tasks
@sklam sklam marked this pull request as ready for review March 19, 2024 17:53
@sklam sklam added this to the 0.60.0-rc1 milestone Mar 19, 2024
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the cherry-picked 🍒 commits are correct and have the correct diff. I manually inspected the remaining commits to ensure that they are correct. I checked the changes to towncrier_checker.py changes and could confirm, that without these changes, we would end up with a list of false positives on this branch:

 💣 zsh» python maint/towncrier_checker.py --token YYY --beginning 0.59.0dev0 --repo numba/numba
PRs that are missing towncrier notes and not skipped
8990 https://github.com/numba/numba/pull/8990
9048 https://github.com/numba/numba/pull/9048
9058 https://github.com/numba/numba/pull/9058
9089 https://github.com/numba/numba/pull/9089
9123 https://github.com/numba/numba/pull/9123
9126 https://github.com/numba/numba/pull/9126
9140 https://github.com/numba/numba/pull/9140
9141 https://github.com/numba/numba/pull/9141
9144 https://github.com/numba/numba/pull/9144
9154 https://github.com/numba/numba/pull/9154
9169 https://github.com/numba/numba/pull/9169
9189 https://github.com/numba/numba/pull/9189

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Mar 22, 2024
@sklam sklam merged commit 1085604 into numba:main Mar 22, 2024
21 checks passed
@sklam sklam deleted the misc/postrel0591 branch March 22, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge skip_release_notes Skip towncrier requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants