Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added np.size() overload and added tests #9504

Merged
merged 11 commits into from Apr 16, 2024
Merged

added np.size() overload and added tests #9504

merged 11 commits into from Apr 16, 2024

Conversation

shourya5
Copy link
Contributor

@kc611
Copy link
Collaborator

kc611 commented Mar 26, 2024

Hi @shourya5, Thank you for your contribution. 😄

As this feature will be mentioned in our next release notes, could you add a short description of this feature as a small release note .rst file. Here are the instructions to do so.

kc611
kc611 requested changes Mar 26, 2024
View reviewed changes
numba/tests/test_array_manipulation.py Show resolved Hide resolved
numba/tests/test_record_dtype.py Show resolved Hide resolved
@shourya5 shourya5 requested a review from kc611 March 27, 2024 11:15
@guilhermeleobas guilhermeleobas added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review labels Apr 4, 2024
guilhermeleobas
guilhermeleobas requested changes Apr 4, 2024
View reviewed changes
docs/upcoming_changes/9504.np_support.rst Outdated Show resolved Hide resolved
numba/tests/test_array_manipulation.py Outdated Show resolved Hide resolved
numba/tests/test_array_manipulation.py Outdated Show resolved Hide resolved
shourya5 and others added 3 commits April 4, 2024 23:36
@shourya5 @guilhermeleobas
Update docs/upcoming_changes/9504.np_support.rst
0ba90da 
Co-authored-by: Guilherme Leobas <guilhermeleobas@gmail.com>
@shourya5 @guilhermeleobas
Update numba/tests/test_array_manipulation.py
9d8d040 
Co-authored-by: Guilherme Leobas <guilhermeleobas@gmail.com>
@shourya5 @guilhermeleobas
Update numba/tests/test_array_manipulation.py
3178902 
Co-authored-by: Guilherme Leobas <guilhermeleobas@gmail.com>
@shourya5 @guilhermeleobas
Update docs/upcoming_changes/9504.np_support.rst
83c1782 
Co-authored-by: Guilherme Leobas <guilhermeleobas@gmail.com>
guilhermeleobas
guilhermeleobas approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@guilhermeleobas guilhermeleobas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shourya5. Just waiting for @kc611 approval and this one can be merged.

kc611
kc611 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@kc611 kc611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @shourya5 @guilhermeleobas

@guilhermeleobas guilhermeleobas added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Apr 10, 2024
@guilhermeleobas guilhermeleobas added this to the 0.60.0-rc1 milestone Apr 10, 2024
@sklam sklam merged commit e749f05 into numba:main Apr 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermeleobas guilhermeleobas guilhermeleobas approved these changes

@kc611 kc611 kc611 approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge numpy
Projects
None yet
Milestone
0.60.0-rc1
Development

Successfully merging this pull request may close these issues.

The np.size() Function Fails
4 participants
@shourya5 @kc611 @guilhermeleobas @sklam