Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds conda_dependencies to GitSource #2

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

jrbourbeau
Copy link
Contributor

This PR adds a conda_dependencies property to the GitSource class for installing source project-related dependencies into the test environment. This is similar to how dependencies are installed for the GitTarget class.

Motivating example

When setting up a GitSource for Dask and a GitTarget for XArray, the install_command property for Dask could be either pip install -e . to just install Dask, or pip install -e .[complete] to install Dask and its dependencies from PyPI. However, it would be nice to not mix pip installed dependencies from Dask and conda installed dependencies from XArray. Moreover, other projects may have difficult to install dependencies so conda installing deps would be more than just a preference.

What do you think about this approach @esc?

@esc
Copy link
Member

esc commented Jul 19, 2019

LGMT! Thanks for the patch!

@esc esc merged commit 35c0a6d into numba:master Jul 19, 2019
@jrbourbeau jrbourbeau deleted the add-source-conda-deps branch July 19, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants