Adds conda_dependencies to GitSource #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
conda_dependencies
property to theGitSource
class for installing source project-related dependencies into the test environment. This is similar to how dependencies are installed for theGitTarget
class.Motivating example
When setting up a
GitSource
for Dask and aGitTarget
for XArray, theinstall_command
property for Dask could be eitherpip install -e .
to just install Dask, orpip install -e .[complete]
to install Dask and its dependencies from PyPI. However, it would be nice to not mixpip
installed dependencies from Dask andconda
installed dependencies from XArray. Moreover, other projects may have difficult to install dependencies soconda
installing deps would be more than just a preference.What do you think about this approach @esc?