fix rendering of time spent in SCORM cmi.session_time

It was creating a Date object and using the getHours/Minutes/Seconds methods, but `(new Date(0)).getHours() == 1`, so it was always an hour off. This replaces that with some simple arithmetic.
numbas · Nov 28, 2022 · accdb43 · accdb43
1 parent 9dddb2f
commit accdb43
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/runtime/scripts/scorm-storage.js b/runtime/scripts/scorm-storage.js
@@ -684,8 +684,12 @@ SCORMStorage.prototype = /** @lends Numbas.storage.SCORMStorage.prototype */ {
      */
     setSessionTime: function()
     {
-        var timeSpent = new Date(this.exam.timeSpent*1000);
-        var sessionTime = 'PT'+timeSpent.getHours()+'H'+timeSpent.getMinutes()+'M'+timeSpent.getSeconds()+'S';
+        var timeSpent = this.exam.timeSpent;
+        var seconds = Math.floor(timeSpent % 60);
+        var minutes = Math.floor(timeSpent/60) % 60;
+        var hours = Math.floor(timeSpent/60/60);
+
+        var sessionTime = 'PT' + hours + 'H' + minutes + 'M' + seconds + 'S';
         this.set('session_time',sessionTime);
     },
 

diff --git a/tests/numbas-runtime.js b/tests/numbas-runtime.js
@@ -26253,8 +26253,12 @@ SCORMStorage.prototype = /** @lends Numbas.storage.SCORMStorage.prototype */ {
      */
     setSessionTime: function()
     {
-        var timeSpent = new Date(this.exam.timeSpent*1000);
-        var sessionTime = 'PT'+timeSpent.getHours()+'H'+timeSpent.getMinutes()+'M'+timeSpent.getSeconds()+'S';
+        var timeSpent = this.exam.timeSpent;
+        var seconds = Math.floor(timeSpent % 60);
+        var minutes = Math.floor(timeSpent/60) % 60;
+        var hours = Math.floor(timeSpent/60/60);
+
+        var sessionTime = 'PT' + hours + 'H' + minutes + 'M' + seconds + 'S';
         this.set('session_time',sessionTime);
     },