Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the display options button to the question-only theme #814

Closed
christianp opened this issue Mar 29, 2021 · 2 comments
Closed

Add the display options button to the question-only theme #814

christianp opened this issue Mar 29, 2021 · 2 comments
Labels
good first issue Interface

Comments

@christianp
Copy link
Member

No description provided.

@alisahq
Copy link
Contributor

alisahq commented Apr 4, 2022

Hi Christian,

I'd like to pick up this issue. Would you mind if you explain more about the expectations/the files to change for this issue?

Thanks so much and I appreciate your help!

Best,
Alisa

@christianp
Copy link
Member Author

The default theme has a button labelled "Display options" in the sidebar:
Screenshot 2022-04-05 at 09-07-47 Assessment 1 - preview - clppc Numbas

The question theme doesn't have the sidebar, since it's designed only for previewing one question. It would be nice to have the "display options" button somewhere, though. The question theme is in themes/question, and just overrides a few of the templates from the default theme.

I'm not sure where the button should go. Maybe under the question-nav bar?

@alisahq alisahq mentioned this issue Apr 7, 2022
Closed
christianp added a commit that referenced this issue Aug 30, 2022
@christianp
add the "display options" button to the footer of the question theme
aa52b8a 
fixes #814

I think this is the safest place to put it, since footer.html is small
so shouldn't change much.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christianp @alisahq