Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'nonzero' and 'nonone' annotations for the $n special pattern matcher #840

Closed
christianp opened this issue Jun 29, 2021 · 3 comments
Closed

Comments

@christianp
Copy link
Member

christianp commented Jun 29, 2021

These would be useful for insisting that a coefficient is worth including.

The annotations that change $n's behaviour are defined in runtime/scripts/jme-rules.js, in number_conditions. To implement this, add entries for nonzero and nonone which check that tok.value != 0 (or 1)

@odavarci
Copy link
Contributor

odavarci commented Oct 3, 2021

Can I take this issue?

@christianp
Copy link
Member Author

@odavarci thanks for offering to help! Please look at our guidance on contributing to Numbas. For this issue, you only need this repository, the Numbas runtime - the editor isn't necessary.

@odavarci
Copy link
Contributor

odavarci commented Oct 5, 2021

@christianp, I pulled a request.

christianp added a commit to numbas/editor that referenced this issue Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants