Show a warning when no LMS is connected #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes numbas#529. There is now a variable Numbas.storage.lmsConnected telling us whether a true SCORM connection to an LMS exists. The front page uses this variable to show a warning message explaining that marks and answers are not saved when there is no SCORM connection.
christianp
requested changes
Apr 26, 2018
runtime/scripts/scorm-storage.js
Outdated
| @@ -20,12 +20,14 @@ var scorm = Numbas.storage.scorm = {}; | |||
| */ | |||
| var SCORMStorage = scorm.SCORMStorage = function() | |||
| { | |||
| Numbas.storage.lmsConnected = true; | |||
There was a problem hiding this comment.
I would prefer to have this as false to begin with, and set it to true if the SCORM API is found.
There was a problem hiding this comment.
In fact, this could be set to false in the prototype of SCORMStorage, which would let you add a documentation tag.
Sets lmsConnected to false by default, setting it to true only when a SCORM connection is established.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529. There is now a variable Numbas.storage.lmsConnected telling us
whether a true SCORM connection to an LMS exists.
The front page uses this variable to show a warning message explaining that
marks and answers are not saved when there is no SCORM connection.