Diagnosys: Add a finish action when you are retrying the last question. #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is only one action: the retry, which is then automatically executed and gives a strange flickery effect without the student really knowing what happened.
jhoobergs
force-pushed
the
improve/diagnosys_script
branch
from
b721c7d
to
861693f
Compare
|
@christianp Any comment on this? (no hurry :) ) |
|
Sorry it took me so long to look at this! This change seems good, and I've merged it. I made the text "End the test" translatable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you are retrying the last question, there is only one action: the retry, which is then automatically executed and gives a strange flickery effect without the student really knowing what happened. This PR adds a stop action which stops the exam by not setting a next question. This implies that there are 2 possible actions in the end, which prevents the flickery effect by letting the student decide whether to retry or not. It also fixes the next_diagnostic_question which didn't check for null.